Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cmd): support plainHTTP opt for Pull&Push func #153

Merged
merged 1 commit into from
Dec 9, 2020
Merged

feat(cmd): support plainHTTP opt for Pull&Push func #153

merged 1 commit into from
Dec 9, 2020

Conversation

simon-cj
Copy link
Contributor

@simon-cj simon-cj commented Dec 8, 2020 •
edited
Loading

What type of PR is this?
/kind feature
/area model

What this PR does / why we need it:
Support plainHTTP opt for Pull&Push func

Which issue(s) this PR is related to (optional, link to 3rd issue(s)):

Fixes #

Reference to #

Special notes for your reviewer:

/cc @FogDong

Does this PR introduce a user-facing change?:

Support plainHTTP opt for Pull&Push func

@caicloud-bot caicloud-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. area/model Model related functions, including model warehouse, model compression, model evaluation, etc. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 8, 2020
@simon-cj
Copy link
Contributor Author

simon-cj commented Dec 9, 2020

ping @FogDong

@simon-cj simon-cj changed the title feat(cmd): set plain-http as true default feat(cmd): support plainHTTP opt for Pull&Push func Dec 9, 2020
@caicloud-bot caicloud-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 9, 2020
FogDong
FogDong reviewed Dec 9, 2020
View reviewed changes
Copy link
Member

@FogDong FogDong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@caicloud-bot caicloud-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 9, 2020
@caicloud-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FogDong

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@caicloud-bot caicloud-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 9, 2020
@caicloud-bot caicloud-bot merged commit b485d69 into kleveross:master Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FogDong FogDong FogDong left review comments

Assignees

@FogDong FogDong

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/model Model related functions, including model warehouse, model compression, model evaluation, etc. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@simon-cj @caicloud-bot @FogDong